Explicit mapping in labels + frontend improvements #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* explicit mapping in labels * Update frontend/components/traces/add-label.tsx Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> --------- Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to b45f8c4 in 1 minute and 7 seconds
More details
- Looked at
1242lines of code in38files - Skipped
1files when reviewing. - Skipped posting
5drafted comments based on config settings.
1. frontend/components/dataset/dataset-panel.tsx:2
- Draft comment:
The import ofLoaderhas been replaced withLoader2fromlucide-react. Ensure thatLoader2is the intended icon and is available in thelucide-reactpackage. - Reason this comment was not posted:
Confidence changes required:50%
The import ofLoaderfromlucide-reacthas been replaced withLoader2across multiple files. This change is consistent and should be noted.
2. frontend/components/evaluator/evaluator-editor.tsx:174
- Draft comment:
ThevalueMapis now an object instead of an array. Ensure that this change is consistent across the codebase and that all usages ofvalueMapare updated accordingly. - Reason this comment was not posted:
Confidence changes required:50%
The change from using an array forvalueMapto using an object is significant and affects multiple files. This change should be consistent across the codebase.
3. frontend/components/traces/add-label-popover.tsx:388
- Draft comment:
ThevalueMapis now an object instead of an array. Ensure that this change is consistent across the codebase and that all usages ofvalueMapare updated accordingly. - Reason this comment was not posted:
Confidence changes required:50%
The change from using an array forvalueMapto using an object is significant and affects multiple files. This change should be consistent across the codebase.
4. frontend/components/traces/add-label.tsx:132
- Draft comment:
ThevalueMapis now an object instead of an array. Ensure that this change is consistent across the codebase and that all usages ofvalueMapare updated accordingly. - Reason this comment was not posted:
Confidence changes required:50%
The change from using an array forvalueMapto using an object is significant and affects multiple files. This change should be consistent across the codebase.
5. frontend/components/traces/span-labels.tsx:109
- Draft comment:
ThevalueMapis now an object instead of an array. Ensure that this change is consistent across the codebase and that all usages ofvalueMapare updated accordingly. - Reason this comment was not posted:
Confidence changes required:50%
The change from using an array forvalueMapto using an object is significant and affects multiple files. This change should be consistent across the codebase.
Workflow ID: wflow_qhYJcYl4bXW3pdN1
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
frontend/components/ui/formatter.tsx
Outdated
| @@ -61,6 +63,14 @@ export default function Formatter({ | |||
| return value; | |||
| }; | |||
|
|
|||
| const copyToClipboard = () => { | |||
There was a problem hiding this comment.
This functionality duplicates existing clipboard and toast operations found in project-api-keys.tsx. Consider refactoring to use a common utility function.
- function
copyToClipboard(project-api-keys.tsx)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{"label": numeric_val}instead of an array and use of indexes.Important
This pull request updates label mapping to use explicit key-value pairs, enhances UI with a copy button and responsive design, updates loader icons, and adjusts CSS variables for consistency.
evaluator-editor.tsx,add-label-popover.tsx, andadd-label.tsx.formatter.tsxfor copying formatted text.projects.tsx.LoadertoLoader2in multiple components includingdataset-panel.tsx,dataset-upload.tsx, anddelete-datapoints-dialog.tsx.globals.cssfor better visual consistency.next-authto version4.24.10inpackage.json.This description was created by
for b45f8c4. It will automatically update as commits are pushed.